chore: add release/test workflows for github ci #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShookLyngs
force-pushed
the
chore-workflows
branch
from
cda2dfe
to
071d4e9
Compare
ahonn
approved these changes
Nov 10, 2023
Dawn-githup
approved these changes
Nov 10, 2023
Dawn-githup
approved these changes
Nov 10, 2023
Dawn-githup
approved these changes
Nov 10, 2023
Dawn-githup
approved these changes
Nov 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
releaseworkflow to publish packages in a clean environment instead of locallytestworkflow to test the features of the packages in pull requestspackage.jsoninfo of root and the core packageRelevant todos
NPM_TOKENGITHUB_TOKENExtras
The turbo issue
@ahonn reported that after the
pnpm run build:packagescommand, thelibfolder only contains a few files instead of the full expected content. I identified that the issue was related to the malfunctioning ofturbo run. The problem was resolved after I cleared the repository cache.To prevent this from happening again, I have created the
releaseworkflow. Running it in the GitHub CI (a clean environment) should help prevent such issues. When a bump commit has been merged, we can trigger thereleaseworkflow manually.Disable
testby defaultThe
testworkflow should fail at this point because not all tests are ready to run in automation. Therefore, I believe thetestworkflow should be disabled by default until the tests are well organized/updated.